PS1 section not working

This topic has 4 replies, 2 voices, and was last updated 1 month ago by Nathan_K.

Viewing 4 reply threads

Author

Posts

25 March, 2023 at 7:59 am #5803

Participant

I’ve had some issues with GETHTTP not returning data consistently, so I decided to write a small PS1 section to do the same task. The script I wrote works perfectly in a PowerShell window, but when I put it into a [section] it doesn’t work.

## v1.0 -- Retrieve IPv4, IPv6 and Reverse DNS for IPv4

## Output headers
# Write-Host wan_ipv4 &#039;,&#039; wan_ipv6 &#039;,&#039; wan_rdns

Try { $IPv4_addr = (Invoke-WebRequest -Uri https://ip4.seeip.org/ -UseBasicParsing -ErrorAction &#039;Stop&#039; | Select -ExpandProperty Content) }#
	Catch { $IPv4_addr = &quot;&quot; }
Try { $IPv6_addr = (Invoke-WebRequest -Uri https://ip6.seeip.org/ -UseBasicParsing -ErrorAction &#039;Stop&#039; | Select -ExpandProperty Content) }
	Catch { $IPv6_addr = &quot;&quot; }
Try { $IPv4_rdns = (Invoke-WebRequest -Uri https://ipinfo.io/$IPv4_addr/hostname -UseBasicParsing -ErrorAction &#039;Stop&#039; | Select -ExpandProperty Content) }
	Catch { $IPv4_rdns = &quot;&quot; }

Write-Host $IPv4_addr &#039;,&#039; $IPv6_addr &#039;,&#039; $IPv4_rdns
Exit 0

## v1.0 -- Retrieve IPv4, IPv6 and Reverse DNS for IPv4

## Output headers

# Write-Host wan_ipv4 ',' wan_ipv6 ',' wan_rdns

Try { $IPv4_addr = (Invoke-WebRequest -Uri https://ip4.seeip.org/ -UseBasicParsing -ErrorAction 'Stop' | Select -ExpandProperty Content) }#

Catch { $IPv4_addr = "" }

Try { $IPv6_addr = (Invoke-WebRequest -Uri https://ip6.seeip.org/ -UseBasicParsing -ErrorAction 'Stop' | Select -ExpandProperty Content) }

Catch { $IPv6_addr = "" }

Try { $IPv4_rdns = (Invoke-WebRequest -Uri https://ipinfo.io/$IPv4_addr/hostname -UseBasicParsing -ErrorAction 'Stop' | Select -ExpandProperty Content) }

Catch { $IPv4_rdns = "" }

Write-Host $IPv4_addr ',' $IPv6_addr ',' $IPv4_rdns

Exit 0

If I use it as a PowerShell script call, it works:
CMD=interval:120,color:55cc77,text:WAN Address,read-as-csv:1,csv-header:0,file:powershell.exe, parameters:".\Scripts\wan-ip-lookup.ps1",trim:1,show-window:0,hide-no-result:1, display:{{{IPv4: %1 }}}{{{IPv6: %2}}}{{{ |Reverse DNS: %3}}}

If I call it directly from the [wan-ip-lookup] section I created, I get errors.

SET-SECTION=key:wan-ip-lookup,value:wan-ip-lookup.ps1
CMD=interval:120,color:55cc77,text:WAN Address,read-as-csv:1,csv-header:0,file:powershell.exe, parameters:-Command &quot;&amp; { %wan-ip-lookup% }&quot;,trim:1,show-window:0,hide-no-result:1, display:{{{IPv4: %1   }}}{{{IPv6: %2}}}{{{ |Reverse DNS: %3}}}

1 2	SET-SECTION=key:wan-ip-lookup,value:wan-ip-lookup.ps1 CMD=interval:120,color:55cc77,text:WAN Address,read-as-csv:1,csv-header:0,file:powershell.exe, parameters:-Command "& { %wan-ip-lookup% }",trim:1,show-window:0,hide-no-result:1, display:{{{IPv4: %1 }}}{{{IPv6: %2}}}{{{ \|Reverse DNS: %3}}}

Any assistance would be appreciated, as I’d rather have it contained in a section vs an external script.

Thanks!

25 March, 2023 at 8:02 am #5806
Glenn
Keymaster
I’ll look into this shortly.

3 April, 2023 at 10:23 am #5822

Glenn

Keymaster

I’ll try and convey this without mangling the code:

[wan-ip-lookup.ps1]
## v1.0 -- Retrieve IPv4, IPv6 and Reverse DNS for IPv4

## Output headers
# Write-Host wan_ipv4 "," wan_ipv6 "," wan_rdns

Try { $IPv4_addr = (Invoke-WebRequest -Uri https://ip4.seeip.org/ -UseBasicParsing -ErrorAction "Stop" | Select -ExpandProperty Content) }#
	Catch { $IPv4_addr = '' }
Try { $IPv6_addr = (Invoke-WebRequest -Uri https://ip6.seeip.org/ -UseBasicParsing -ErrorAction "Stop" | Select -ExpandProperty Content) }
	Catch { $IPv6_addr = '' }
Try { $IPv4_rdns = (Invoke-WebRequest -Uri https://ipinfo.io/$IPv4_addr/hostname -UseBasicParsing -ErrorAction "Stop" | Select -ExpandProperty Content) }
	Catch { $IPv4_rdns = '' }

Write-Host $IPv4_addr","$IPv6_addr","$IPv4_rdns

[wan-ip-lookup.ps1]

## v1.0 -- Retrieve IPv4, IPv6 and Reverse DNS for IPv4

## Output headers

# Write-Host wan_ipv4 "," wan_ipv6 "," wan_rdns

Try { $IPv4_addr = (Invoke-WebRequest -Uri https://ip4.seeip.org/ -UseBasicParsing -ErrorAction "Stop" | Select -ExpandProperty Content) }#

Catch { $IPv4_addr = '' }

Try { $IPv6_addr = (Invoke-WebRequest -Uri https://ip6.seeip.org/ -UseBasicParsing -ErrorAction "Stop" | Select -ExpandProperty Content) }

Catch { $IPv6_addr = '' }

Try { $IPv4_rdns = (Invoke-WebRequest -Uri https://ipinfo.io/$IPv4_addr/hostname -UseBasicParsing -ErrorAction "Stop" | Select -ExpandProperty Content) }

Catch { $IPv4_rdns = '' }

Write-Host $IPv4_addr","$IPv6_addr","$IPv4_rdns

SET-SECTION=key:wan-ip-lookup,value:wan-ip-lookup.ps1
CMD=interval:120,color:55cc77,text:WAN Address,read-as-csv:1,csv-header:0,file:powershell.exe, parameters:-Command %wan-ip-lookup%,trim:1,show-window:0,hide-no-result:1, display:IPv4: %1   IPv6: %2 |Reverse DNS: %3

1 2	SET-SECTION=key:wan-ip-lookup,value:wan-ip-lookup.ps1 CMD=interval:120,color:55cc77,text:WAN Address,read-as-csv:1,csv-header:0,file:powershell.exe, parameters:-Command %wan-ip-lookup%,trim:1,show-window:0,hide-no-result:1, display:IPv4: %1 IPv6: %2 \|Reverse DNS: %3

getting the single/double quote characters right is all important. the third return value has something in there that’s messing up the csv output.

probably worth adding no-wait:1 as well.

This reply was modified 1 month ago by Glenn.
This reply was modified 1 month ago by Glenn.

3 April, 2023 at 11:31 am #5825

Glenn

Keymaster

Ok, this version sorts out the null values:

[wan-ip-lookup.ps1]
## v1.0 -- Retrieve IPv4, IPv6 and Reverse DNS for IPv4

## Output headers
# Write-Host wan_ipv4 "," wan_ipv6 "," wan_rdns

Try { $IPv4_addr = (Invoke-WebRequest -Uri https://ip4.seeip.org/ -UseBasicParsing -ErrorAction "Stop" | Select -ExpandProperty Content) }#
	Catch { $IPv4_addr = '' }
Try { $IPv6_addr = (Invoke-WebRequest -Uri https://ip6.seeip.org/ -UseBasicParsing -ErrorAction "Stop" | Select -ExpandProperty Content) }
	Catch { $IPv6_addr = '' }
Try { $IPv4_rdns = (Invoke-WebRequest -Uri https://ipinfo.io/$IPv4_addr/hostname -UseBasicParsing -ErrorAction "Stop" | Select -ExpandProperty Content) }
	Catch { $IPv4_rdns = '' }
if($IPv4_addr.Trim().Length -eq 0) {$IPv4_addr='<null>'}
if($IPv6_addr.Trim().Length -eq 0) {$IPv6_addr='<null>'}
if($IPv4_rdns.Trim().Length -eq 0) {$IPv4_rdns='<null>'}
Write-Host $IPv4_addr','$IPv6_addr','$IPv4_rdns

[wan-ip-lookup.ps1]

## v1.0 -- Retrieve IPv4, IPv6 and Reverse DNS for IPv4

## Output headers

# Write-Host wan_ipv4 "," wan_ipv6 "," wan_rdns

Try { $IPv4_addr = (Invoke-WebRequest -Uri https://ip4.seeip.org/ -UseBasicParsing -ErrorAction "Stop" | Select -ExpandProperty Content) }#

Catch { $IPv4_addr = '' }

Try { $IPv6_addr = (Invoke-WebRequest -Uri https://ip6.seeip.org/ -UseBasicParsing -ErrorAction "Stop" | Select -ExpandProperty Content) }

Catch { $IPv6_addr = '' }

Try { $IPv4_rdns = (Invoke-WebRequest -Uri https://ipinfo.io/$IPv4_addr/hostname -UseBasicParsing -ErrorAction "Stop" | Select -ExpandProperty Content) }

Catch { $IPv4_rdns = '' }

if($IPv4_addr.Trim().Length -eq 0) {$IPv4_addr='<null>'}

if($IPv6_addr.Trim().Length -eq 0) {$IPv6_addr='<null>'}

if($IPv4_rdns.Trim().Length -eq 0) {$IPv4_rdns='<null>'}

Write-Host $IPv4_addr','$IPv6_addr','$IPv4_rdns

SET-SECTION=key:wan-ip-lookup,value:wan-ip-lookup.ps1
CMD=interval:120,color:55cc77,text:WAN Address,read-as-csv:1,csv-header:0,file:powershell.exe, parameters:-Command %wan-ip-lookup%,trim:1,show-window:0,hide-no-result:1, display:{{{IPv4: %1   }}}{{{IPv6: %2}}}{{{|Reverse DNS: %3}}}

1 2	SET-SECTION=key:wan-ip-lookup,value:wan-ip-lookup.ps1 CMD=interval:120,color:55cc77,text:WAN Address,read-as-csv:1,csv-header:0,file:powershell.exe, parameters:-Command %wan-ip-lookup%,trim:1,show-window:0,hide-no-result:1, display:{{{IPv4: %1 }}}{{{IPv6: %2}}}{{{\|Reverse DNS: %3}}}

This reply was modified 1 month ago by Glenn.

4 April, 2023 at 4:26 pm #5835

Nathan_K

Participant

Thanks Glenn.. I had made several revisions to the original PS1 since posting, so here’s the updated version as a block that works inside the .ini file.

[wan-ip-lookup.ps1]
## v1.0 -- Retrieve IPv4, IPv6 and Reverse DNS for IPv4
## v1.1 -- Updated to use Invoke-RestMethod instead of Invoke-WebRequest
## v1.2 -- Added secondary Uri for IPv4 and IPv6

## Output headers
Write-Host wan_ipv4 &#039;,&#039; wan_rdns &#039;,&#039; wan_ipv6

Try { $IPv4_addr = (Invoke-RestMethod -Uri https://ip4.seeip.org/ -UseBasicParsing -ErrorAction &quot;Stop&quot;) }
	Catch { Try { $IPv4_addr = (Invoke-RestMethod -Uri https://4.tnedi.me/ -UseBasicParsing -ErrorAction &quot;Stop&quot;) }
		Catch { $IPv4_addr = &#039;n/a&#039; }
	}
Try { $IPv6_addr = (Invoke-RestMethod -Uri https://ip6.seeip.org/ -UseBasicParsing -ErrorAction &quot;Stop&quot;) }
	Catch { Try { $IPv6_addr = (Invoke-RestMethod -Uri https://6.tnedi.me/ -UseBasicParsing -ErrorAction &quot;Stop&quot;) }
		Catch {	$IPv6_addr = &#039;n/a&#039; }
	}
Try {
		$IPv4_rdns = (Invoke-RestMethod -Uri https://ipinfo.io/$IPv4_addr/hostname -UseBasicParsing -ErrorAction &quot;Stop&quot;).Trim()
		If ( -not $IPv4_rdns ) { $IPv4_rdns = &#039;No record found&#039; }
    }
	Catch { $IPv4_rdns = &#039;n/a&#039; }

Write-Host $IPv4_addr &#039;,&#039; $IPv4_rdns &#039;,&#039; $IPv6_addr
Exit 0

[wan-ip-lookup.ps1]

## v1.0 -- Retrieve IPv4, IPv6 and Reverse DNS for IPv4

## v1.1 -- Updated to use Invoke-RestMethod instead of Invoke-WebRequest

## v1.2 -- Added secondary Uri for IPv4 and IPv6

## Output headers

Write-Host wan_ipv4 ',' wan_rdns ',' wan_ipv6

Try { $IPv4_addr = (Invoke-RestMethod -Uri https://ip4.seeip.org/ -UseBasicParsing -ErrorAction "Stop") }

Catch { Try { $IPv4_addr = (Invoke-RestMethod -Uri https://4.tnedi.me/ -UseBasicParsing -ErrorAction "Stop") }

Catch { $IPv4_addr = 'n/a' }

}

Try { $IPv6_addr = (Invoke-RestMethod -Uri https://ip6.seeip.org/ -UseBasicParsing -ErrorAction "Stop") }

Catch { Try { $IPv6_addr = (Invoke-RestMethod -Uri https://6.tnedi.me/ -UseBasicParsing -ErrorAction "Stop") }

Catch { $IPv6_addr = 'n/a' }

}

Try {

$IPv4_rdns = (Invoke-RestMethod -Uri https://ipinfo.io/$IPv4_addr/hostname -UseBasicParsing -ErrorAction "Stop").Trim()

If ( -not $IPv4_rdns ) { $IPv4_rdns = 'No record found' }

}

Catch { $IPv4_rdns = 'n/a' }

Write-Host $IPv4_addr ',' $IPv4_rdns ',' $IPv6_addr

Exit 0

SET-SECTION=key:wan-ip-lookup,value:wan-ip-lookup.ps1
CMD=interval:120,color:55cc77,text:WAN Address,read-as-csv:1,csv-header:1,file:powershell.exe, \
  parameters:-Command %wan-ip-lookup%,trim:1,show-window:0,hide-no-result:1, \
  display:{{{IPv4: %1}}}{{{   IPv6: %3}}}{{{ |Reverse DNS: %2}}}

SET-SECTION=key:wan-ip-lookup,value:wan-ip-lookup.ps1

CMD=interval:120,color:55cc77,text:WAN Address,read-as-csv:1,csv-header:1,file:powershell.exe, \