bug in del_old_driverpacks.bat

[Ben Dubin]

The driverpack cleanup batch file wrongfully attempts to delete DP_Sounds_Realtek_22035.7z, even though this driverpack is up to date (included in the latest driverpack torrent.)

I’m no expert, but it looks like it’s confusing DP_Sounds_Realtek_DCH_22043.7z as a newer version when the DCH and non-DCH should be seen as separate and unrelated packs.

[Glenn]

You are totally correct and thanks for bringing that to my attention. The DCH file is new this release and I missed it. I’ve updated the batch file to better support the new variation.

Here’s the new version (watch out for extraneous code tags, they are the backticks):

MS DOS

@echo off echo Snappy Driver Installer Origin echo Driver Pack Cleanup echo by Computer Bloke echo. @setlocal enableextensions @cd /d "%~dp0/drivers" attrib *.* -R rem out of date driver packs for /f "tokens=1,2,3,4,5,6,7 delims=_. usebackq" %%i in (<code>dir /b *.7z</code>) do call :cleanup %%i %%j %%k %%l %%m %%n %%o rem redundant driver packs del DP_Sound_ADI_*.7z 2> nul cd .. goto :end :cleanup if /i "%7"=="7z" call :clean7 %1 %2 %3 %4 %5 %6 && goto :eof if /i "%6"=="7z" call :clean6 %1 %2 %3 %4 %5 && goto :eof if /i "%5"=="7z" call :clean5 %1 %2 %3 %4 && goto :eof if /i "%4"=="7z" call :clean4 %1 %2 %3 && goto :eof if /i "%3"=="7z" call :clean3 %1 %2 && goto :eof goto :eof :clean7 for /f "tokens=* usebackq" %%f in (<code>dir /b /on "%1_%2_%3_%4_%5_?????.7z"</code>) do set "GOODFILE=%%f" echo Keeping most recent driver file: %GOODFILE% for %%f in (%1_%2_%3_%4_%5_?????.7z) do if not "%%f"=="%GOODFILE%" echo "%%f" & del "%%f" goto :eof :clean6 for /f "tokens=* usebackq" %%f in (<code>dir /b /on "%1_%2_%3_%4_?????.7z"</code>) do set "GOODFILE=%%f" echo Keeping most recent driver file: %GOODFILE% for %%f in (%1_%2_%3_%4_?????.7z) do if not "%%f"=="%GOODFILE%" echo "%%f" & del "%%f" goto :eof :clean5 for /f "tokens=* usebackq" %%f in (<code>dir /b /on "%1_%2_%3_?????.7z"</code>) do set "GOODFILE=%%f" echo Keeping most recent driver file: %GOODFILE% for %%f in (%1_%2_%3_?????.7z) do if not "%%f"=="%GOODFILE%" echo "%%f" & del "%%f" goto :eof :clean4 for /f "tokens=* usebackq" %%f in (<code>dir /b /on "%1_%2_?????.7z"</code>) do set "GOODFILE=%%f" echo Keeping most recent driver file: %GOODFILE% for %%f in (%1_%2_?????.7z) do if not "%%f"=="%GOODFILE%" echo "%%f" & del "%%f" goto :eof :clean3 for /f "tokens=* usebackq" %%f in (<code>dir /b /on "%1_?????.7z"</code>) do set "GOODFILE=%%f" echo Keeping most recent driver file: %GOODFILE% for %%f in (%1_?????.7z) do if not "%%f"=="%GOODFILE%" echo "%%f" & del "%%f" goto :eof :end

1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 43 44 45 46 47 48 49 50 51 52 53 54 55

@echo off echo Snappy Driver Installer Origin echo Driver Pack Cleanup echo by Computer Bloke echo. @setlocal enableextensions @cd /d "%~dp0/drivers" attrib *.* -R   rem out of date driver packs for /f "tokens=1,2,3,4,5,6,7 delims=_. usebackq" %%i in (<code>dir /b *.7z</code>) do call :cleanup %%i %%j %%k %%l %%m %%n %%o rem redundant driver packs del DP_Sound_ADI_*.7z 2> nul cd .. goto :end   :cleanup if /i "%7"=="7z" call :clean7 %1 %2 %3 %4 %5 %6 && goto :eof if /i "%6"=="7z" call :clean6 %1 %2 %3 %4 %5 && goto :eof if /i "%5"=="7z" call :clean5 %1 %2 %3 %4 && goto :eof if /i "%4"=="7z" call :clean4 %1 %2 %3 && goto :eof if /i "%3"=="7z" call :clean3 %1 %2 && goto :eof goto :eof   :clean7 for /f "tokens=* usebackq" %%f in (<code>dir /b /on "%1_%2_%3_%4_%5_?????.7z"</code>) do set "GOODFILE=%%f" echo Keeping most recent driver file: %GOODFILE% for %%f in (%1_%2_%3_%4_%5_?????.7z) do if not "%%f"=="%GOODFILE%" echo "%%f" & del "%%f" goto :eof   :clean6 for /f "tokens=* usebackq" %%f in (<code>dir /b /on "%1_%2_%3_%4_?????.7z"</code>) do set "GOODFILE=%%f" echo Keeping most recent driver file: %GOODFILE% for %%f in (%1_%2_%3_%4_?????.7z) do if not "%%f"=="%GOODFILE%" echo "%%f" & del "%%f" goto :eof   :clean5 for /f "tokens=* usebackq" %%f in (<code>dir /b /on "%1_%2_%3_?????.7z"</code>) do set "GOODFILE=%%f" echo Keeping most recent driver file: %GOODFILE% for %%f in (%1_%2_%3_?????.7z) do if not "%%f"=="%GOODFILE%" echo "%%f" & del "%%f" goto :eof   :clean4 for /f "tokens=* usebackq" %%f in (<code>dir /b /on "%1_%2_?????.7z"</code>) do set "GOODFILE=%%f" echo Keeping most recent driver file: %GOODFILE% for %%f in (%1_%2_?????.7z) do if not "%%f"=="%GOODFILE%" echo "%%f" & del "%%f" goto :eof   :clean3 for /f "tokens=* usebackq" %%f in (<code>dir /b /on "%1_?????.7z"</code>) do set "GOODFILE=%%f" echo Keeping most recent driver file: %GOODFILE% for %%f in (%1_?????.7z) do if not "%%f"=="%GOODFILE%" echo "%%f" & del "%%f" goto :eof   :end

• This reply was modified 1 year ago by Glenn.
• This reply was modified 1 year ago by Glenn.
• This reply was modified 1 year ago by Glenn.

[Ben Dubin]

Thank You!

[Pier B]

I use such a file DelOldDP.bat found on the web and everything works, even with the latest packs from Samlab

@echo off setlocal enableextensions for %%a in (&quot;%~dp0drivers\DP_*.7z&quot;) do call :ProcessDP &quot;%%~na&quot; goto :eof :ProcessDP call :GetPrefSuff %1 if &quot;%Pref%&quot;==&quot;&quot; goto :eof if &quot;%Suff%&quot;==&quot;&quot; goto :eof for %%b in (&quot;%~dp0drivers\%Pref%*.7z&quot;) do call :DelIfOld &quot;%%~nb&quot; &quot;%Pref%&quot; &quot;%Suff%&quot; goto :eof :DelIfOld call :GetPrefSuff %1 if &quot;%Pref%&quot;==&quot;&quot; goto :eof if &quot;%Suff%&quot;==&quot;&quot; goto :eof if %~3 LEQ %Suff% goto :eof echo Deleting old DP - &quot;%Pref%%Suff%.7z&quot; del /f /q &quot;%~dp0drivers\%Pref%%Suff%.7z&quot; goto :eof :GetPrefSuff set Suff= set Pref=%~1 call :PrefixRec goto :eof :PrefixRec set LastCh=%Pref:~-1% if &quot;%LastCh%&quot;==&quot;&quot; goto :eof if &quot;%LastCh%&quot;==&quot;_&quot; goto :eof set Suff=%LastCh%%Suff% set Pref=%Pref:~0,-1% call :PrefixRec goto :eof

1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36

@echo off setlocal enableextensions   for %%a in ("%~dp0drivers\DP_*.7z") do call :ProcessDP "%%~na" goto :eof   :ProcessDP call :GetPrefSuff %1 if "%Pref%"=="" goto :eof if "%Suff%"=="" goto :eof for %%b in ("%~dp0drivers\%Pref%*.7z") do call :DelIfOld "%%~nb" "%Pref%" "%Suff%" goto :eof   :DelIfOld call :GetPrefSuff %1 if "%Pref%"=="" goto :eof if "%Suff%"=="" goto :eof if %~3 LEQ %Suff% goto :eof echo Deleting old DP - "%Pref%%Suff%.7z" del /f /q "%~dp0drivers\%Pref%%Suff%.7z" goto :eof   :GetPrefSuff set Suff= set Pref=%~1 call :PrefixRec goto :eof   :PrefixRec set LastCh=%Pref:~-1% if "%LastCh%"=="" goto :eof if "%LastCh%"=="_" goto :eof set Suff=%LastCh%%Suff% set Pref=%Pref:~0,-1% call :PrefixRec goto :eof

[Pier B]

DelOldDP.bat

Attachments:

1. DelOldDP.7z

[Author]

Posts